Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry image is overridden when referencing registry from cluster #344

Closed
RedbackThomson opened this issue Jun 17, 2024 · 1 comment · Fixed by #345
Closed

Registry image is overridden when referencing registry from cluster #344

RedbackThomson opened this issue Jun 17, 2024 · 1 comment · Fixed by #345
Labels
bug Something isn't working

Comments

@RedbackThomson
Copy link

I am attempting to apply the following manifest:

apiVersion: ctlptl.dev/v1alpha1
kind: Registry
name: ctlptl-registry
port: 5001
listenAddress: 127.0.0.1
image: <my-private-registry-image>
---
apiVersion: ctlptl.dev/v1alpha1
kind: Cluster
product: kind
registry: ctlptl-registry
kindV1Alpha4Cluster:
  ...

However, it appears that when applying the Cluster type, ctlptl will override the image of the private registry back to the default docker/registry:2 image. Ideally, it would not change anything about the registry and use it as it is.

In order to get around this for the moment, I am first applying the Cluster (which creates ctlptl-registry with the default registry image) and then applying the Registry to override it back to use my private image.

@nicks
Copy link
Member

nicks commented Jun 18, 2024

thanks for the report! ya i can repro

@nicks nicks added the bug Something isn't working label Jun 18, 2024
nicks added a commit that referenced this issue Jun 18, 2024
the old logic wasn't doing the 3-way merge quite right

fixes #344

Signed-off-by: Nick Santos <nick.santos@docker.com>
@nicks nicks closed this as completed in b9c0b12 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants