Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modification with ctlptl docker-desktop set results in status code 400 #267

Closed
kbakk opened this issue Dec 6, 2022 · 1 comment · Fixed by #268
Closed

Modification with ctlptl docker-desktop set results in status code 400 #267

kbakk opened this issue Dec 6, 2022 · 1 comment · Fixed by #268

Comments

@kbakk
Copy link

kbakk commented Dec 6, 2022

Example:

$ ctlptl docker-desktop set vm.kubernetes.enabled false
ctlptl docker-desktop: writing docker-desktop settings: status code 400
$ ctlptl docker-desktop set vm.resources.cpus 2
ctlptl docker-desktop: writing docker-desktop settings: status code 400

OS: MacOS 12.5.1
Docker version: v4.14.1
Docker Desktop Kubernetes version: v1.25.2
ctlptl version: v0.8.12, built 2022-11-04
@nicks
Copy link
Member

nicks commented Dec 7, 2022

🤔 🤔 🤔 thanks for reporting!

nicks added a commit that referenced this issue Dec 14, 2022
@nicks
cluster: fix settings write payload
453030c 
also, while i'm here, refactor the protocol negotiation to better
express what's happening and match the socket names on disk

fixes #267

Signed-off-by: Nick Santos <nick.santos@docker.com>
@nicks nicks mentioned this issue Dec 14, 2022
Merged
nicks added a commit that referenced this issue Dec 14, 2022
@nicks
cluster: fix settings write payload (#268)
9991a12 
also, while i'm here, refactor the protocol negotiation to better
express what's happening and match the socket names on disk

fixes #267

Signed-off-by: Nick Santos <nick.santos@docker.com>

Signed-off-by: Nick Santos <nick.santos@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cluster: fix settings write payload tilt-dev/ctlptl
2 participants
@nicks @kbakk