rename per comment

tilt-dev · Nov 27, 2024 · 57ded97 · 57ded97
1 parent af80d17
commit 57ded97
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/examples/kind_extra_args.yaml b/examples/kind_extra_args.yaml
@@ -3,7 +3,7 @@ apiVersion: ctlptl.dev/v1alpha1
 kind: Cluster
 product: kind
 registry: ctlptl-registry
-kindExtraArguments:
+kindExtraCreateArguments:
 # Example 1: Pass --wait to `kind create cluster` to wait for the control plane to be ready.
 - "--wait=2m"
 # Example 2: Pass --retain to `kind create cluster` to keep the containers around.

diff --git a/pkg/api/types.go b/pkg/api/types.go
@@ -62,8 +62,8 @@ type Cluster struct {
 	// wins over one specified in the Kind config.
 	KindV1Alpha4Cluster *v1alpha4.Cluster `json:"kindV1Alpha4Cluster,omitempty" yaml:"kindV1Alpha4Cluster,omitempty"`
 
-	// Extra command line arguments passed to Kind CLI. Only applicable to clusters with the product: kind.
-	KindExtraArguments []string `json:"kindExtraArguments,omitempty" yaml:"kindExtraArguments,omitempty"`
+	// Extra command line arguments passed to Kind create CLI. Only applicable to clusters with the product: kind.
+	KindExtraCreateArguments []string `json:"kindExtraCreateArguments,omitempty" yaml:"kindExtraCreateArguments,omitempty"`
 
 	// The Minikube cluster config. Only applicable for clusters with product: minikube.
 	Minikube *MinikubeCluster `json:"minikube,omitempty" yaml:"minikube,omitempty"`

diff --git a/pkg/cluster/admin_kind.go b/pkg/cluster/admin_kind.go
@@ -147,7 +147,7 @@ func (a *kindAdmin) Create(ctx context.Context, desired *api.Cluster, registry *
 		return errors.Wrap(err, "creating kind cluster")
 	}
 
-	args = append(args, desired.KindExtraArguments...)
+	args = append(args, desired.KindExtraCreateArguments...)
 	args = append(args, "--config", "-")
 
 	iostreams := a.iostreams