[5.3] Fail-safing Queue's Predis/Redis Unit Tests & Move to phpunit.x…

…ml.dist (laravel#14696)

* Refactored testing setup:
- renamed phpunit.xml to phpunit.xml.dist (supported by phpunit)
- added phpunit.xml to the .gitignore
- added commented out redis configuration
- Redis based tests are skipped when configuration not present

* - Added default parameter/connection checking to Queue's Redis integration tests
- Failsafe skipping for default connection
- Added connection timeout of .5s for Predis

* Style fixes

.gitignore

@@ -4,3 +4,4 @@ composer.lock
 .php_cs.cache
 .DS_Store
 Thumbs.db
+/phpunit.xml

phpunit.xml → phpunit.xml.dist

@@ -26,4 +26,10 @@
             </exclude>
         </whitelist>
     </filter>
+    <php>
+      <!--
+      <env name="REDIS_HOST" value="127.0.0.1" />
+      <env name="REDIS_PORT" value="6379" />
+      -->
+    </php>
 </phpunit>

tests/Queue/RedisQueueIntegrationTest.php

@@ -8,6 +8,11 @@
 
 class RedisQueueIntegrationTest extends PHPUnit_Framework_TestCase
 {
+    /**
+     * @var bool
+     */
+    private static $connectionFailedOnceWithDefaultsSkip = false;
+
     /**
      * @var Database
      */
@@ -21,15 +26,36 @@ class RedisQueueIntegrationTest extends PHPUnit_Framework_TestCase
     public function setUp()
     {
         parent::setUp();
+
+        $host = getenv('REDIS_HOST') ?: '127.0.0.1';
+        $port = getenv('REDIS_PORT') ?: 6379;
+
+        if (static::$connectionFailedOnceWithDefaultsSkip) {
+            $this->markTestSkipped('Trying default host/port failed, please set environment variable REDIS_HOST & REDIS_PORT to enable '.__CLASS__);
+
+            return;
+        }
+
         $this->redis = new Database([
             'cluster' => false,
             'default' => [
-                'host' => '127.0.0.1',
-                'port' => 6379,
+                'host' => $host,
+                'port' => $port,
                 'database' => 5,
+                'timeout' => 0.5,
             ],
         ]);
-        $this->redis->connection()->flushdb();
+
+        try {
+            $this->redis->connection()->flushdb();
+        } catch (\Exception $e) {
+            if ($host === '127.0.0.1' && $port === 6379 && getenv('REDIS_HOST') === false) {
+                $this->markTestSkipped('Trying default host/port failed, please set environment variable REDIS_HOST & REDIS_PORT to enable '.__CLASS__);
+                static::$connectionFailedOnceWithDefaultsSkip = true;
+
+                return;
+            }
+        }
 
         $this->queue = new RedisQueue($this->redis);
         $this->queue->setContainer(m::mock(Container::class));
@@ -39,7 +65,9 @@ public function tearDown()
     {
         parent::tearDown();
         m::close();
-        $this->redis->connection()->flushdb();
+        if ($this->redis) {
+            $this->redis->connection()->flushdb();
+        }
     }
 
     public function testExpiredJobsArePopped()