Add new "7 segment display" device type. Synthetize it when 8 bit output is named "display7". #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put is named "display7".
|
This PR has a lot of stylistic changes included. Unfortunately, they make reviewing the PR very hard. Could you change the PR to include only the functional changes? (Some preferred coding style should be adopted for the project, and it should be automatically checked on each commit/PR in Github Actions. But it's a task which should be done in another PR.) |
|
Oh... I didn't notice that while pushing. Would it be ok if I made two separate commits? One for functional changes and the other one for format improvements? |
|
Yes, this would be okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be merged when, the master branch of the
digitaljspackage will support this element.Do not merge before tilk/digitaljs#84 is merged to
digitaljs's master branch!