Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set height on nested elements to avoid mutliple scrollbars #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fleaz
Copy link

@fleaz fleaz commented Jul 20, 2021

Hey,

even with the latest version I was still struggling with #180 even on different screens and resolutions so I decided to create a small PR to make this awesome extension a tiny bit better :)

Best,
Felix

Before

After

@tilfin
Copy link
Member

tilfin commented Jul 20, 2021

@fleaz Could you tell me your OS and browser, screen scaling percent?

@fleaz
Copy link
Author

fleaz commented Jul 20, 2021

OS: Arch Linux
Browser: Chromium 91
Screen: 4K
Scaling: Between 1,3x and 1,5x

popup.html Outdated Show resolved Hide resolved
@tilfin
Copy link
Member

tilfin commented Jul 25, 2021

@fleaz I didn't reproduce this situation in my environment.

Scaling: Between 1,3x and 1,5x

Can you tell me how to set this up?

@fleaz
Copy link
Author

fleaz commented Jul 26, 2021

I just talked to a colleague of mine who also uses this plugin and also has this issue and we found the root cause of this :)

This happens when you go to Settings -> Apperance and configure a Page Zoom higher than 100% (Mine was e.g. on 125% because I run a highDPI display and want things to be a bit bigger). In contrast to the normal zooming on a website with Ctrl+ +/- which only changes the page ocntent, the PageZoom you configure in the settings also has an effect on your browser extensions which causes the double scrollbar issue.

@tilfin
Copy link
Member

tilfin commented Aug 7, 2021

@fleaz Thank you, I could recoginize it.

@tilfin
Copy link
Member

tilfin commented Aug 15, 2021

Hmm, the height is not automatically expanded in my Windows environment.
image

@tilfin tilfin force-pushed the main branch 2 times, most recently from b58bfb3 to 9a7ceff Compare January 17, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants