-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contours #1925
base: master
Are you sure you want to change the base?
Contours #1925
Changes from 6 commits
010b764
e3f6290
af927b9
c080e56
267ce64
a53f1ef
cfbbf7c
a1f4643
695eb6e
232e531
418ad3f
642a9dc
78dff55
929a71f
96b959f
491cf5e
adc5b80
7ae7d2a
7fde574
41ce83f
fa5ccd2
6317c98
8a8e4c8
666a1b8
5da5876
bb871ed
8cc10cd
b77fc23
019f204
dc274e8
d49abdf
0b910e4
5db46fe
385cd1d
53aeb5e
d5b138b
cb36bc4
ee08f37
9411f4c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
SELECT | ||
|
||
osm_id AS __id__, | ||
|
||
{% filter geometry %}{{ bounds['line']|bbox_intersection('way') }}{% endfilter %} AS __geometry__, | ||
|
||
-- common properties across all layers | ||
jsonb_build_object( | ||
'source', 'viewfinderpanoramas.org', | ||
'min_zoom', 13, | ||
'ele', ele | ||
) AS __contours_properties__ | ||
|
||
FROM ( | ||
|
||
SELECT | ||
|
||
osm_id, | ||
ele, | ||
way | ||
|
||
FROM | ||
|
||
contours | ||
|
||
WHERE | ||
|
||
{{ bounds['line']|bbox_filter('way', 3857) }} | ||
|
||
) p |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,6 +108,9 @@ | |
- {$layer: 'water', kind: 'sea'} | ||
- {$layer: 'pois', kind: 'nature_reserve'} | ||
- {$layer: 'water', kind: 'lake'} | ||
# for contours | ||
- _reserved: {count: 10} | ||
- {$layer: 'contours', kind: 'std'} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kind should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would put this at the very bottom of the file... just above the default value. These contour in this file are just for the label collisions, which should be least priority. If there are "index" contours (eg with a kind_detail) then those should have priority over generic contours. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated according to your first comment. |
||
# for shields & etc | ||
- _reserved: {count: 10} | ||
- {$layer: 'roads', kind: 'highway', kind_detail: 'motorway'} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
kind,sort_rank | ||
*,1500 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should go between dam and breakwater, so reserve a slot there, and value more like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated according to your comment. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
global: | ||
- &output_properties | ||
source: {col: source} | ||
min_zoom: {col: min_zoom} | ||
ele: {col: ele} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
So we'll probably need a new transform to assign There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated according to your first comment. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure how to add this new transfor to assign |
||
|
||
filters: | ||
- filter: | ||
geom_type: line | ||
min_zoom: 13 | ||
table: vfp | ||
output: | ||
<<: *output_properties | ||
kind: std | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be an optional layer for the mainline build... and a fork could put it into the
all
grouping.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated according to your comment.