Bugfix: handle double trailing slashes in paths #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why should this be fixed inside recognize and not before being passed into recognize? |
krisselden
reviewed
May 11, 2017
| @@ -24,6 +24,14 @@ QUnit.test("A simple route recognizes", (assert: Assert) => { | |||
| assert.equal(router.recognize("/foo/baz"), null); | |||
| }); | |||
|
|
|||
| QUnit.test("A simple route with double trailing slashes recognizes", (assert: Assert) => { | |||
There was a problem hiding this comment.
If recognize should clean these, why is it only important to clean the trailing double slashes?
|
Hmm, I thought we already decided this? We landed emberjs/ember.js#14961, do we still need this PR too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found by @stefanpenner, double trailing slashes caused hard errors when recognizing paths.
Changes:
recognizeto handle trimming double trailing slashesHow to test drive this PR:
npm startQuestion: Do we need to collapse ε segments throughout the path?