-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Embroider v1 deps; Drop node v10 #74
Conversation
Pushed a commit adding ember-source as peer dep because newer embroider macros's dependencySatisfies needs it to work reliable. See embroider-build/embroider#1070 Tests should pass now. |
Failing tests are due to Ember v4 requiring ember-auto-import v2. Which can be solved in other PR. |
Since that is a different issue I'm going to merge this as is |
thanks! |
@josemarluedke to clarify, are you upgrading ember-auto-import next? |
@cibernox PR coming. |
Can we get a release with this? 🙂 |
I think we can merge #73 and then release it. Looking forward to have a release out as well. |
adding more search keywords here, updating to
error for me, as I understand, it's related to |
Node 10 is not compatible with embroider v1.