-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pnpm
#108
Switch to pnpm
#108
Conversation
.npmrc
Outdated
public-hoist-pattern[]=!@typescript-eslint/* | ||
public-hoist-pattern[]=*ember-template-lint* | ||
public-hoist-pattern[]=*stylelint* | ||
strict-peer-dependencies=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strict-peers needs to be true for all libraries, can you delete this file? thanks!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Hoisting the lint packages is so far necessary for vscode plugins to properly work.
}, | ||
"volta": { | ||
"node": "14.21.3", | ||
"yarn": "1.22.19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add pnpm here? 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very close!!! nice work and thanks for working on this! left a couple comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
No description provided.