Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pnpm #108

Merged
merged 12 commits into from
Aug 2, 2023
Merged

Switch to pnpm #108

merged 12 commits into from
Aug 2, 2023

Conversation

gossi
Copy link
Contributor

@gossi gossi commented Jul 26, 2023

No description provided.

.npmrc Outdated
public-hoist-pattern[]=!@typescript-eslint/*
public-hoist-pattern[]=*ember-template-lint*
public-hoist-pattern[]=*stylelint*
strict-peer-dependencies=false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict-peers needs to be true for all libraries, can you delete this file? thanks!!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Hoisting the lint packages is so far necessary for vscode plugins to properly work.

},
"volta": {
"node": "14.21.3",
"yarn": "1.22.19",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add pnpm here? 🥳

Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very close!!! nice work and thanks for working on this! left a couple comments

Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@NullVoxPopuli NullVoxPopuli merged commit 17c675e into tildeio:main Aug 2, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants