Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge BackgroundGC with TEST_StartGC #94

Merged
merged 4 commits into from
Oct 16, 2019
Merged

merge BackgroundGC with TEST_StartGC #94

merged 4 commits into from
Oct 16, 2019

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Oct 11, 2019 •
edited
Loading

  • merge BackgroundGC with TEST_StartGC
  • Add test for destroying column family hande

@Connor1996
merge TEST_StartGC with BackgroundGC
b4a400d 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996 Connor1996 changed the title [WIP] Add column family check for GC merge BackgroundGC with TEST_StartGC Oct 12, 2019
@Connor1996 Connor1996 requested a review from yiwu-arbug October 12, 2019 09:39
@codecov-io
Copy link

Codecov Report

Merging #94 into master will decrease coverage by 0.15%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   86.22%   86.07%   -0.16%     
==========================================
  Files          44       44              
  Lines        3165     3145      -20     
==========================================
- Hits         2729     2707      -22     
- Misses        436      438       +2

@yiwu-arbug
Copy link
Collaborator

Awesome! I was wanting to merge it, too.

yiwu-arbug
yiwu-arbug approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/db_impl_gc.cc Show resolved Hide resolved
@Connor1996
Copy link
Member Author

@yiwu-arbug Thanks for your commits!

@Connor1996 Connor1996 merged commit 8ac5003 into tikv:master Oct 16, 2019
@Connor1996 Connor1996 deleted the seg branch October 16, 2019 01:36
yiwu-arbug pushed a commit to yiwu-arbug/titan that referenced this pull request Oct 16, 2019
@Connor1996
merge BackgroundGC with TEST_StartGC (tikv#94)
6a8413c 
* merge TEST_StartGC with BackgroundGC

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
yiwu-arbug pushed a commit that referenced this pull request Oct 16, 2019
Fix Titan missing blob issue (#97)
43225d4 
Cherry-picking the following patches for fixing #93 
```
0a3f87a 2019-10-15 yiwu@pingcap.com     Temp fix for data loss caused by concurrent flush (#96)
8ac5003 2019-10-16 zbk602423539@gmail.. merge BackgroundGC with TEST_StartGC (#94)
b9915d9 2019-10-07 zbk602423539@gmail.. check nullptr (#91)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiwu-arbug yiwu-arbug yiwu-arbug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Connor1996 @codecov-io @yiwu-arbug