copr: the stats for normal column should be based on collation key (#8105) #8620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ikv#8105) Signed-off-by: Yiding Cui <winoros@gmail.com> Conflicts: Cargo.toml src/coprocessor/statistics/analyze.rs
breezewish
approved these changes
Sep 8, 2020
|
/run-all-tests |
|
/run-integration-ddl-test |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Sep 8, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@winoros merge failed. |
|
/run-integration-common-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #8105
What problem does this PR solve?
Issue Number: for pingcap/tidb#14689
Problem Summary:
We should use the collation key instead of its original value for a normal column to generate its statistics.
What is changed and how it works?
What's Changed:
Use the collation sort key as the sampling data.
Related changes
Check List
Tests
Side effects
Release note