-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: fix incorrect resolved ts timeout #8573
Conversation
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
components/cdc/src/endpoint.rs
Outdated
futures03::future::join(tso, timeout.compat().map_err(|_| unreachable!())).await; | ||
let _ = timeout.compat().await; | ||
// Ignore get tso errors since we will retry every `min_ts_interval`. | ||
let mut min_ts = tso.unwrap_or_default(); | ||
let mut min_ts = tso.await.unwrap_or_default(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tso response arrives immediately, it still delays a timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. By the way is the latency shorter now?
/merge |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #8588 |
Yes, previously resolved ts has at least 1s gap and now it was eliminated. |
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers tangminghua@pingcap.com
What problem does this PR solve?
Problem Summary:
Resolved ts was advanced periodically by getting tso and waiting for timeout simultaneously, which makes tso delayed.
What is changed and how it works?
Get tso after timeout.
Proposal: xxx
What's Changed:
Related changes
Check List
Tests
Release note