raftstore: consider wake-up msg when checking stale msg in peer fsm (#7592) #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/raft
gengliqi
force-pushed
the
release-3.0-d37dac2aed81
branch
from
72aef34 to
37db263
Compare
overvenus
approved these changes
Apr 21, 2020
BusyJay
approved these changes
Apr 21, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
gengliqi
force-pushed
the
release-3.0-d37dac2aed81
branch
from
b4b712e to
1ee15cb
Compare
Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
gengliqi
force-pushed
the
release-3.0-d37dac2aed81
branch
from
1ee15cb to
6a122bc
Compare
|
/run-all-tests |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
/run-all-tests |
Signed-off-by: Liqi Geng <gengliqiii@gmail.com>
|
/merge |
gengliqi
force-pushed
the
release-3.0-d37dac2aed81
branch
from
0bf863d to
577d4b7
Compare
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #7592 to release-3.0
Signed-off-by: Liqi Geng gengliqiii@gmail.com
What problem does this PR solve?
Problem Summary:
In #7416, we check wake-up msg in store fsm, this logic will be triggered only when the asked peer has already destroyed. But if the asked peer exists, it will ignore the wake-up msg and the problem is similar to #7416.
Although the learner who sends wake-up msg can be destroyed after querying to PD in this case, it needs several minutes which is too slow.
What is changed and how it works?
What's Changed:
Do not ignore the wake-up msg in peer fsm.
Related changes
Check List
Tests
Side effects
No
Release note
Using the same release note as #7416