Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/gc_worker: Add more metrics (#4705) #4922

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

MyonKeminta
Copy link
Contributor

Signed-off-by: MyonKeminta MyonKeminta@users.noreply.github.com

What have you changed? (mandatory)

This PR cherry-picks PR #4705 which added more metrics for GC.

What are the type of the changes? (mandatory)

  • Improvement (change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)

Manual test, previously tested in #4705

Does this PR affect documentation (docs) or release note? (mandatory)

  • No

Does this PR affect tidb-ansible update? (mandatory)

NO

* Add more metrics about GC

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Address comments

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Address comments

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Remove redundant metrics updating

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Address comments

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta
Copy link
Contributor Author

@zhangjinpeng1987 @AndreMouche PTAL

@MyonKeminta MyonKeminta added component/storage Component: Storage, Scheduler, etc. type/cherry-pick Type: PR - Cherry pick labels Jun 19, 2019
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyonKeminta MyonKeminta added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jun 19, 2019
@zhangjinpeng87
Copy link
Member

/run-all-tests tidb=release-3.0 pd=release-3.0

@zhangjinpeng87
Copy link
Member

/run-all-tests tidb=release-3.0 pd=release-3.0

@MyonKeminta MyonKeminta merged commit ad2a2f4 into tikv:release-3.0 Jun 20, 2019
@MyonKeminta MyonKeminta deleted the misono/gc-metrics-3.0 branch June 20, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/storage Component: Storage, Scheduler, etc. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants