txn: remove scheduler #4098
Merged
txn: remove scheduler #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siddontang <siddontang@gmail.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
|
Please provide some bench results. |
overvenus
reviewed
Jan 21, 2019
siddontang
reviewed
Jan 22, 2019
siddontang
reviewed
Jan 22, 2019
siddontang
reviewed
Jan 22, 2019
Connor1996
reviewed
Jan 22, 2019
overvenus
added
component/storage
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
|
/test |
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
|
/release |
Signed-off-by: qupeng <qupeng@pingcap.com>
Connor1996
reviewed
May 17, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
nolouch
reviewed
May 17, 2019
|
|
||
| fn dequeue_task(&self, cid: u64) -> Task { | ||
| let mut tasks = self.task_contexts[id_index(cid)].lock().unwrap(); | ||
| let task = tasks.get_mut(&cid).unwrap().task.take().unwrap(); |
There was a problem hiding this comment.
I think use remove directly is more clear.
There was a problem hiding this comment.
There is an Option<Task> in TaskContext. When getting a snapshot we need to get the inner Task but leave the TaskContext.
| } | ||
| } | ||
|
|
||
| fn dequeue_task_context(&self, cid: u64) -> TaskContext { |
There was a problem hiding this comment.
Seems duplicate with dequeue_task?
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
nolouch
approved these changes
May 20, 2019
jswh
pushed a commit
to jswh/tikv
that referenced
this pull request
May 27, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Reomve scheduler thread. So in the current implement introduced by this PR, callers dispatch messages to schedule-worker directly instead of scheduler first.
What are the type of the changes? (mandatory)
Improvement.
How has this PR been tested? (mandatory)
Unit tests and integration tests.
Does this PR affect documentation (docs) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.