bindgen: pre-generate bindings #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fredchenbj <cfworking@163.com>
Connor1996
reviewed
Dec 17, 2019
librocksdb_sys/build.rs
Outdated
| // Other platforms use bindgen to generate the bindings every time. | ||
| fn config_binding_path() { | ||
| let file_path: PathBuf; | ||
| println!("cargo:rerun-if-changed=bindings/x86_64-unknown-linux-gnu-bindings.rs"); |
There was a problem hiding this comment.
Please add cargo:rerun-if-env-changed=UPDATE_BIND, and remove this cause it will forbid rerun when other files changed in librocksdb_sys/*
|
Sorry for the late review, LGTM overall |
Signed-off-by: fredchenbj <cfworking@163.com>
|
/run-all-tests |
yiwu-arbug
reviewed
Dec 19, 2019
| @@ -23,6 +23,7 @@ sse = ["libtitan_sys/sse"] | |||
| [build-dependencies] | |||
| cc = "1.0.3" | |||
| cmake = "0.1" | |||
| bindgen = "0.52" | |||
There was a problem hiding this comment.
seems bindgen 0.52 is conflicting with grpcio, which is using bindgen 0.51. Any thoughts on how to fix?
There was a problem hiding this comment.
use bindgen 0.51 to fix it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is extraced from pr #398 to make code review easier.
Like grpc-rs pr tikv/grpc-rs#356, this pr pre-generate the bindings. Later, I would finish pr #398 based on this pre-generated bindings.
Signed-off-by: fredchenbj cfworking@163.com