use bytes for protobuf #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
May 17, 2021
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
force-pushed
the
protobuf-use-bytes
branch
6 times, most recently
from
af2c5ae
to
f922a5f
Compare
BusyJay
reviewed
May 20, 2021
BusyJay
reviewed
May 20, 2021
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
BusyJay
previously approved these changes
May 24, 2021
Signed-off-by: qupeng <qupeng@pingcap.com>
gengliqi
approved these changes
May 24, 2021
BusyJay
approved these changes
May 24, 2021
|
/merge |
NingLin-P
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qupeng qupeng@pingcap.com
Waiting for tikv/protobuf-build#50.
If
protobuf-codecis enabled,byteswill be used to replaceVec<u8>for protobufbytestype.However if
prost-codecis enabled,Vec<u8>will be still used.