*: introduce joint quorum #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ports joint quorum. It rename ProgressSet to ProgressTracker and keep both name and field layout just like etcd. In addition, the PR fixes a performance issue discoverred earlier that campaign prints too much logs. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
@Fullstop000 PTAL if you have time. |
Connor1996
reviewed
Jul 6, 2020
src/raft.rs
Outdated
| ); | ||
| let mut m = new_message(*id, vote_msg, None); | ||
|
|
||
| if voter_cnt < 7 { |
There was a problem hiding this comment.
why 7? why just let it print all at the end even it's more than 7.
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Fullstop000
reviewed
Jul 6, 2020
src/tracker.rs
Outdated
| /// right away when entering the joint configuration, so that it is caught up | ||
| /// as soon as possible. | ||
| #[get = "pub"] | ||
| learner_next: HashSet<u64>, |
There was a problem hiding this comment.
Prefer learners_next to follow learners
Fullstop000
reviewed
Jul 6, 2020
src/raft.rs
Outdated
| ); | ||
| let mut m = new_message(*id, vote_msg, None); | ||
|
|
||
| if voter_cnt == 7 { |
There was a problem hiding this comment.
Maybe use voters.len() instead
There was a problem hiding this comment.
voters is an array, its length is always 7.
There was a problem hiding this comment.
I think it could be better to use voter_cnt == voters.len() to replace the magic number
Fullstop000
reviewed
Jul 6, 2020
src/quorum/joint.rs
Outdated
Comment on lines
40
to
42
| let i_idx = self.incoming.committed_index(use_group_commit, l); | ||
| let o_idx = self.outgoing.committed_index(use_group_commit, l); | ||
| (cmp::min(i_idx.0, o_idx.0), i_idx.1 && o_idx.1) |
There was a problem hiding this comment.
Maybe using tuple destructuring could be more readable?
let (i_idx, i_use_group) = self.incoming.committed_index(use_group_commit, l);
let (o_idx, o_use_group) = self.outgoing.committed_index(use_group_commit, l);
(cmp::min(i_idx, o_idx), i_use_group && o_use_group)Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
LGTM |
Connor1996
approved these changes
Jul 8, 2020
|
Thanks! @Connor1996 @Fullstop000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports joint quorum. It rename ProgressSet to ProgressTracker
and keep both name and field layout just like etcd.
In addition, the PR fixes a performance issue discovered earlier that
campaign prints too much logs.
joint.rs is ported from etcd/raft/quorum/joint.go and tracker is from
etcd/raft/tracker/tracker.go.