check pending reads when quorum becomes small #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
BusyJay
reviewed
May 14, 2020
src/raft.rs
Outdated
| @@ -2325,4 +2305,21 @@ impl<T: Storage> Raft<T> { | |||
| m.request_snapshot = self.pending_request_snapshot; | |||
| self.send(m); | |||
| } | |||
|
|
|||
| fn response_ready_read(&mut self, mut req: Message, index: u64) -> Option<Message> { | |||
There was a problem hiding this comment.
s/response_ready_read/handle_ready_read_index/
|
|
||
| // The quorum size is now smaller, consider to response some read requests. | ||
| // If there is only one peer, all pending read requests must be responsed. | ||
| if let Some(ctx) = self.read_only.last_pending_request_ctx() { |
There was a problem hiding this comment.
What if some reads in the front of the queue are ready to be processed?
There was a problem hiding this comment.
Without iterating the pending queue, they can only become ready when more heartbeat responses are received. Do you have any solution to handle them without iterating?
| @@ -4920,3 +4920,36 @@ fn test_group_commit_consistent() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_read_when_quorum_becomes_small() { | |||
There was a problem hiding this comment.
Please add comment what it is testing.
Signed-off-by: qupeng <qupeng@pingcap.com>
BusyJay
previously approved these changes
May 14, 2020
|
/run-all-tests |
|
/rebuild |
gengliqi
reviewed
May 20, 2020
| @@ -4920,3 +4920,38 @@ fn test_group_commit_consistent() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // `test_read_when_quorum_becomes_small` tests read requests could be handled earlier | |||
There was a problem hiding this comment.
Seems it should be test_read_when_quorum_becomes_less?
Signed-off-by: qupeng <qupeng@pingcap.com>
gengliqi
approved these changes
May 20, 2020
BusyJay
approved these changes
May 21, 2020
hicqu
added a commit
that referenced
this pull request
May 25, 2020
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
added a commit
to hicqu/raft-rs
that referenced
this pull request
May 25, 2020
Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #345 .
Signed-off-by: qupeng qupeng@pingcap.com