Ease protobuf dependency to match kvproto #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
BusyJay
previously approved these changes
Feb 13, 2019
BusyJay
reviewed
Feb 13, 2019
src/eraftpb.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| // This file is generated by rust-protobuf 2.2.4. Do not edit | |||
| // This file is generated by rust-protobuf 2.2.2. Do not edit | |||
There was a problem hiding this comment.
Can it work with protobuf <2.2? For example, will code generated by new compiler use a new API missing in old version?
There was a problem hiding this comment.
I haven't seen a build error or test error from this. I think we could even allow "~2.0-~2.2"
BusyJay
approved these changes
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prepare-to-release patch for 0.5.0 which will ensure there is no required follow up version change in
kvproto(https://github.com/pingcap/kvproto/blob/master/Cargo.toml#L13) leading to https://github.com/tikv/tikv/blob/master/Cargo.toml#L118 which is matches with TiKV's https://github.com/tikv/tikv/blob/master/Cargo.toml#L72.