Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the newly available stable clippy. Fix lints. #124

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Use the newly available stable clippy. Fix lints. #124

merged 2 commits into from
Sep 21, 2018

Conversation

Hoverbear
Copy link
Contributor

We can now use clippy on stable so we don't need it on nightly.

  • We now recommend contributors to use stable instead of having nightly as well for clippy.
  • We now run clippy on stable instead of nightly.
  • Nightly is still tested for nightly users.

@Hoverbear Hoverbear added the Tooling/Testing CI, benchmarking, and testing infrastucture. label Sep 18, 2018
@Hoverbear Hoverbear added this to the 0.5.0 milestone Sep 18, 2018
@Hoverbear Hoverbear self-assigned this Sep 18, 2018
@Hoverbear Hoverbear mentioned this pull request Sep 19, 2018
Merged
siddontang
siddontang approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PTAL @BusyJay @overvenus @hicqu

overvenus
overvenus approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear Hoverbear added the Do Not Merge A blocked PR. Please do not merge it. label Sep 20, 2018
@Hoverbear
Copy link
Contributor Author

Blocked on #123

@Hoverbear Hoverbear removed the Do Not Merge A blocked PR. Please do not merge it. label Sep 21, 2018
@Hoverbear Hoverbear merged commit 32040f2 into master Sep 21, 2018
@Hoverbear Hoverbear deleted the clippy-on-stable branch September 21, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddontang siddontang siddontang approved these changes

@overvenus overvenus overvenus approved these changes

@DorianZheng DorianZheng Awaiting requested review from DorianZheng

Assignees

@Hoverbear Hoverbear

Labels
Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @siddontang @overvenus