server: add creating raft cluster when become leader. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No check in getRaftCluster? |
|
LGTM |
| } | ||
| if value == nil { | ||
| return nil, nil | ||
| return nil |
There was a problem hiding this comment.
Should we return an error here?
There was a problem hiding this comment.
Seems not, if we have not bootstrapped the cluster, then the cluster value from etcd will be nil.
@siddontang Am i right?
There was a problem hiding this comment.
yes, the raft cluster is nil if not bootstrapped.
|
LGTM. |
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Jun 5, 2023
* mcs: fix the members field is null (tikv#6518) close tikv#6519 Signed-off-by: Ryan Leung <rleungx@gmail.com> * mcs, tso: remove unnecessary "create tso forwarding stream" log on the common happy path (tikv#6524) close tikv#6517 Remove unnecessary "create tso forwarding stream" on the common happy path Signed-off-by: Bin Shi <binshi.bing@gmail.com> --------- Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: Bin Shi <binshi.bing@gmail.com> Co-authored-by: Bin Shi <39923490+binshi-bing@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.