Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keypath: remove rootPath from storage and change all paths to absolute path #8919

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

keypath: remove rootPath from storage and change all paths to absolute path #8919

wants to merge 23 commits into from

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Dec 16, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8582

What is changed and how does it work?

  • Organize all keypaths and change them to absolute paths
  • Remove rootpath from the underlying etcd interface of PD

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@okJiang
save work
ec98c72 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Merge branch 'master' of github.com:tikv/pd into key-path-3
1d87074 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
save work
ae0ecb0 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update resource_group and keyspace_group
46daf9d 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update safe point
2cc8896 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update config and rule
2416b53 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
remove rootPath from test file
357bbb4 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhouqiang-cl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2024
@okJiang
fix lint
987316f 
Signed-off-by: okJiang <819421878@qq.com>
okJiang
okJiang commented Dec 19, 2024
View reviewed changes
pkg/mcs/metastorage/server/manager.go
@@ -36,10 +33,6 @@ func NewManager(srv bs.Server) *Manager {
// The first initialization after the server is started.
srv.AddStartCallback(func() {
log.Info("meta storage starts to initialize", zap.String("name", srv.Name()))
m.storage = endpoint.NewStorageEndpoint(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unused.

@okJiang
Merge branch 'master' of github.com:tikv/pd into key-path-3
4cd4bc2 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix regexp
885ae70 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix lint
6a3c636 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix
9fe44ee 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix
8de091e 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix prefix
8c088d7 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ut
6820f69 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix ut
55ab136 
Signed-off-by: okJiang <819421878@qq.com>
@JmPotato JmPotato mentioned this pull request Jan 23, 2025
Open
@okJiang
fix watch
a37c6d7 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix prefix
c10de29 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
fix rule
7484010 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Member Author

okJiang commented Feb 7, 2025

/retest

@okJiang
fix resource group
9217632 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Member Author

okJiang commented Feb 8, 2025

/retest

@okJiang
fix keyspace
344dd00 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Member Author

okJiang commented Feb 8, 2025

/retest

@okJiang okJiang marked this pull request as ready for review February 8, 2025 08:31
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.96413% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.27%. Comparing base (6cadbe7) to head (344dd00).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8919      +/-   ##
==========================================
+ Coverage   76.25%   76.27%   +0.02%     
==========================================
  Files         466      472       +6     
  Lines       70733    71072     +339     
==========================================
+ Hits        53938    54212     +274     
- Misses      13437    13484      +47     
- Partials     3358     3376      +18
Flag Coverage Δ
unittests 76.27% <95.96%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

okJiang
okJiang commented Feb 8, 2025
View reviewed changes
server/gc_service.go Outdated Show resolved Hide resolved
@okJiang
Copy link
Member Author

okJiang commented Feb 8, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

etcd key path is so difficult to read
1 participant
@okJiang