New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: tiny clean up. #89

Merged

siddontang merged 2 commits into siddontang/remove-peer from qiuyesuifeng/remove-peer-cleanup

May 2, 2016

Contributor

qiuyesuifeng commented May 2, 2016

@siddontang PTAL


          server: tiny clean up.

5afa0ea

siddontang reviewed

View reviewed changes

server/command.go

    
              		return nil, errors.New("missing region for changing peer")

              	}

              	if request.LeaderStoreId == nil {

              	if request.GetLeaderStoreId() == 0 {

Contributor

siddontang May 2, 2016

should we need to define INVALID_ID?


          server: add leaderStoreID check for remove peer.

9fd6e89

siddontang merged commit e8fc6a0 into siddontang/remove-peer

siddontang deleted the qiuyesuifeng/remove-peer-cleanup branch

May 2, 2016 13:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet