Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix tso fallback due raft cluster did not stop tso service (#8837) #8838

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8837

What problem does this PR solve?

Issue Number: Close #8836

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@fb992f9). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-8.5    #8838   +/-   ##
==============================================
  Coverage               ?   75.66%           
==============================================
  Files                  ?      461           
  Lines                  ?    72296           
  Branches               ?        0           
==============================================
  Hits                   ?    54706           
  Misses                 ?    14088           
  Partials               ?     3502           
Flag Coverage Δ
unittests 75.66% <72.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 08:05:19.939201641 +0000 UTC m=+105307.558856157: ☑️ agreed by rleungx.
  • 2024-11-21 08:31:19.887342628 +0000 UTC m=+106867.506997144: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 3994172 into tikv:release-8.5 Nov 21, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants