Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make TestStores stable #8522

Merged
merged 3 commits into from
Aug 22, 2024
Merged

*: make TestStores stable #8522

merged 3 commits into from
Aug 22, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Aug 14, 2024

What problem does this PR solve?

Issue Number: Close #7954

What is changed and how does it work?

add a failpoint to make sure the offline store do not convert to tombstone

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.62%. Comparing base (a766351) to head (3abf545).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8522      +/-   ##
==========================================
+ Coverage   77.56%   77.62%   +0.05%     
==========================================
  Files         474      474              
  Lines       61861    61877      +16     
==========================================
+ Hits        47981    48030      +49     
+ Misses      10347    10322      -25     
+ Partials     3533     3525       -8     
Flag Coverage Δ
unittests 77.62% <33.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@okJiang
Copy link
Member Author

okJiang commented Aug 14, 2024

/cc @rleungx @HuSharp

@ti-chi-bot ti-chi-bot bot requested review from HuSharp and rleungx August 14, 2024 09:50
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 16, 2024
Signed-off-by: okJiang <819421878@qq.com>
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-16 04:24:42.645882544 +0000 UTC m=+501167.349352188: ☑️ agreed by nolouch.
  • 2024-08-22 07:52:06.506323377 +0000 UTC m=+424721.640773498: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 9e7a1b9 into tikv:master Aug 22, 2024
21 checks passed
@okJiang okJiang deleted the fix-TestStores branch August 22, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestAPI/TestStores failed
3 participants