-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: fix tso server address compare #8289
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8289 +/- ##
==========================================
+ Coverage 77.31% 77.45% +0.14%
==========================================
Files 470 470
Lines 61517 61385 -132
==========================================
- Hits 47561 47547 -14
+ Misses 10394 10283 -111
+ Partials 3562 3555 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
pkg/mcs/tso/server/grpc_service.go
Outdated
@@ -164,7 +163,7 @@ func (s *Service) FindGroupByKeyspaceID( | |||
Address: member.Address, | |||
// TODO: watch the keyspace groups' primary serving address changes | |||
// to get the latest primary serving addresses of all keyspace groups. | |||
IsPrimary: strings.EqualFold(member.Address, am.GetLeaderAddr()), | |||
IsPrimary: member.CompareAddress(am.GetLeaderAddr()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep consistent with cse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, pd-cse will be switched to release-7.5
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
close tikv#8284 Signed-off-by: lhy1024 <admin@liudos.us>
What problem does this PR solve?
Issue Number: Close #8284
What is changed and how does it work?
Check List
Tests
After
Release note