Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctl: fix https client panic #8239

Merged
merged 6 commits into from
Jun 4, 2024
Merged

ctl: fix https client panic #8239

merged 6 commits into from
Jun 4, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Jun 3, 2024

What problem does this PR solve?

Issue Number: Close #8237, Ref #7300

What is changed and how does it work?

fix panic when call pd-ctl cluster with tls

Check List

Tests

  • Unit test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 3, 2024
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx June 3, 2024 08:04
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2024
Signed-off-by: okJiang <819421878@qq.com>
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.34%. Comparing base (492a873) to head (3b0a7ed).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8239      +/-   ##
==========================================
+ Coverage   77.30%   77.34%   +0.03%     
==========================================
  Files         471      471              
  Lines       61377    61365      -12     
==========================================
+ Hits        47446    47460      +14     
+ Misses      10370    10349      -21     
+ Partials     3561     3556       -5     
Flag Coverage Δ
unittests 77.34% <71.42%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@okJiang okJiang changed the title ctl: fix https client ctl: fix https client panic Jun 3, 2024
Signed-off-by: okJiang <819421878@qq.com>
Signed-off-by: okJiang <819421878@qq.com>
tools/pd-ctl/pdctl/command/global.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2024
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2024
@HuSharp
Copy link
Member

HuSharp commented Jun 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: bba4466

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2024
@okJiang
Copy link
Member Author

okJiang commented Jun 4, 2024

/run-all-tests

Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2024
@JmPotato
Copy link
Member

JmPotato commented Jun 4, 2024

/check-dco

@okJiang okJiang closed this Jun 4, 2024
@okJiang okJiang reopened this Jun 4, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 4, 2024

/check-dco

@ti-chi-bot ti-chi-bot bot added the dco-signoff: no Indicates the PR's author has not signed dco. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Jun 4, 2024
@JmPotato
Copy link
Member

JmPotato commented Jun 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ff1b88a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: yes Indicates the PR's author has signed the dco. labels Jun 4, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jun 4, 2024

/check-dco

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 3b0a7ed Merge branch 'master' into pdctl-tls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot merged commit d44d721 into tikv:master Jun 4, 2024
16 of 19 checks passed
@JmPotato
Copy link
Member

JmPotato commented Jun 4, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@JmPotato: new pull request created to branch release-8.1: #8247.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@okJiang okJiang deleted the pdctl-tls branch June 5, 2024 02:29
ti-chi-bot bot added a commit that referenced this pull request Jul 29, 2024
ref #7300, close #8237

fix panic when call pd-ctl cluster with tls

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: okJiang <819421878@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no Indicates the PR's author has not signed dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when exec "pd health" with tls
6 participants