Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/middleware: avoid redirecting when the leader remains unchanged #8228

Merged
merged 2 commits into from
May 30, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7300.

What is changed and how does it work?

Avoid redirecting when the leader remains unchanged.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 30, 2024
@JmPotato JmPotato added the component/api HTTP API. label May 30, 2024
@ti-chi-bot ti-chi-bot bot requested a review from nolouch May 30, 2024 07:44
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 30, 2024
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label May 30, 2024
@JmPotato JmPotato requested review from rleungx and HuSharp May 30, 2024 07:53
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (52389b0) to head (d027b92).
Report is 1 commits behind head on master.

Current head d027b92 differs from pull request most recent head 64c441e

Please upload reports for the commit 64c441e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8228      +/-   ##
==========================================
+ Coverage   77.26%   77.41%   +0.15%     
==========================================
  Files         470      470              
  Lines       61337    61340       +3     
==========================================
+ Hits        47390    47488      +98     
+ Misses      10377    10291      -86     
+ Partials     3570     3561       -9     
Flag Coverage Δ
unittests 77.41% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2024
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

This pull request has been accepted and is ready to merge.

Commit hash: d027b92

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2024
Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

@JmPotato: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 632cda4 into tikv:master May 30, 2024
15 checks passed
@JmPotato JmPotato deleted the not_redirect_self branch May 30, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants