Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add pending task metrics in runner and add templ #8138

Merged
merged 7 commits into from
May 10, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 29, 2024

What problem does this PR solve?

Issue Number: Ref #7897

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 29, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 29, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx April 29, 2024 08:55
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (44d57b6) to head (b35c0ce).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8138      +/-   ##
==========================================
- Coverage   77.44%   77.40%   -0.05%     
==========================================
  Files         471      471              
  Lines       61348    61356       +8     
==========================================
- Hits        47510    47490      -20     
- Misses      10278    10304      +26     
- Partials     3560     3562       +2     
Flag Coverage Δ
unittests 77.40% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch nolouch requested review from JmPotato and removed request for lhy1024 April 29, 2024 09:09
pkg/ratelimit/runner.go Outdated Show resolved Hide resolved
metrics/grafana/pd.json Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2024
@nolouch nolouch removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2024
metrics/grafana/pd.json Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch
Copy link
Contributor Author

nolouch commented May 10, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 10, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 10, 2024

This pull request has been accepted and is ready to merge.

Commit hash: b35c0ce

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 78cb081 into tikv:master May 10, 2024
25 checks passed
@nolouch nolouch deleted the add-metrics branch May 10, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants