Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: check stats healthy by reference #8132

Merged
merged 6 commits into from
May 6, 2024
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Apr 28, 2024

What problem does this PR solve?

Issue Number: Close #8131 Ref #7897

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

bench config:

round = 100000

store-count = 400
region-count = 10000000
leader-update-ratio = 0.0
epoch-update-ratio = 0.0
space-update-ratio = 0.0
flow-update-ratio = 0.0
no-update-ratio = 0.0

Before
image

After

image

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Apr 28, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 28, 2024
@ti-chi-bot ti-chi-bot bot requested review from HuSharp and rleungx April 28, 2024 03:53
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 77.36%. Comparing base (1679dbc) to head (c6d2fb9).

❗ Current head c6d2fb9 differs from pull request most recent head 3287f5c. Consider uploading reports for the commit 3287f5c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8132   +/-   ##
=======================================
  Coverage   77.35%   77.36%           
=======================================
  Files         471      471           
  Lines       61318    61338   +20     
=======================================
+ Hits        47435    47454   +19     
- Misses      10310    10311    +1     
  Partials     3573     3573           
Flag Coverage Δ
unittests 77.36% <87.03%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: nolouch <nolouch@gmail.com>
pkg/core/region_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 30, 2024
@nolouch
Copy link
Contributor Author

nolouch commented Apr 30, 2024

PTAL @rleungx

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 30, 2024
@nolouch
Copy link
Contributor Author

nolouch commented May 6, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 6, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 6, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c6d2fb9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2024
Copy link
Contributor

ti-chi-bot bot commented May 6, 2024

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit f83feba into tikv:master May 6, 2024
22 checks passed
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
…che reset (#8201)

ref #7897

#8132 introduced a count reference to ensure the consistency between
the root tree and subtrees, however, the reference count was not handled correctly during the cache
reset process, which may lead to incorrect reference counts in later heartbeat processing.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statistics cannot be updated if there are any dropped tasks.
3 participants