Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix scatter counter name #8124

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Apr 25, 2024

What problem does this PR solve?

Issue Number: Close #8125

What is changed and how does it work?

when execute curl -X POST 'http://127.0.0.1:10080/tables/test/t/scatter'

before
image

after
image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2024
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also pick to other branches

@HuSharp
Copy link
Member Author

HuSharp commented Apr 25, 2024

/check-issue-triage-complete

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.37%. Comparing base (de5bad3) to head (7da44ba).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8124      +/-   ##
==========================================
- Coverage   77.39%   77.37%   -0.02%     
==========================================
  Files         471      471              
  Lines       61242    61252      +10     
==========================================
  Hits        47396    47396              
- Misses      10281    10291      +10     
  Partials     3565     3565              
Flag Coverage Δ
unittests 77.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 7da44ba

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 50c8040 into tikv:master Apr 26, 2024
27 checks passed
@HuSharp HuSharp deleted the fix_scatter_range_dispaly branch April 26, 2024 02:13
@HuSharp HuSharp added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Apr 26, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8126.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 26, 2024
close tikv#8125

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8127.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8128.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 26, 2024
close tikv#8125

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8129.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 26, 2024
close #8125

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 26, 2024
close #8125

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 28, 2024
close #8125

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
nolouch pushed a commit to nolouch/pd that referenced this pull request Apr 29, 2024
close tikv#8125

Signed-off-by: husharp <jinhao.hu@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
close #8125

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: husharp <jinhao.hu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scheduler: scatter counter name not display
5 participants