schedule: fix the down peer cannot be repaired #7996

rleungx · 2024-03-28T09:18:56Z

What problem does this PR solve?

Issue Number: Close #7808.

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot · 2024-03-28T09:19:00Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2024-03-28T09:30:20Z

Codecov Report

Merging #7996 (f186939) into master (2b8116e) will decrease coverage by 3.89%.
The diff coverage is 100.00%.

❗ Current head f186939 differs from pull request most recent head 6f425bc. Consider uploading reports for the commit 6f425bc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7996      +/-   ##
==========================================
- Coverage   77.31%   73.42%   -3.89%     
==========================================
  Files         468      436      -32     
  Lines       60867    48478   -12389     
==========================================
- Hits        47058    35594   -11464     
+ Misses      10273     9823     -450     
+ Partials     3536     3061     -475

Flag	Coverage Δ
unittests	`73.42% <100.00%> (-3.89%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

CabinfeverB · 2024-04-09T07:21:49Z

pkg/schedule/checker/replica_strategy.go

@@ -98,7 +98,12 @@ func (s *ReplicaStrategy) SelectStoreToFix(coLocationStores []*core.StoreInfo, o
 	}
 	// trick to avoid creating a slice with `old` removed.
 	s.swapStoreToFirst(coLocationStores, old)
-	return s.SelectStoreToAdd(coLocationStores[1:])
+	// If the coLocationStores only has one store, no need to remove.


In issue desc, there are 3 nodes labeled disk_type=mix. Does it affect 3 nodes case?

What do you mean 3 nodes case?

nolouch · 2024-04-10T05:29:59Z

/merge

ti-chi-bot · 2024-04-10T05:30:01Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-04-10T05:30:02Z

This pull request has been accepted and is ready to merge.

Commit hash: f186939

CabinfeverB · 2024-04-10T05:37:06Z

/check-issue-triage-complete

CabinfeverB · 2024-04-10T05:40:06Z

/merge

ti-chi-bot · 2024-04-10T05:40:08Z

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Smityz · 2024-04-10T09:54:35Z

Thank you! @rleungx

rleungx · 2024-04-10T10:02:55Z

Thank you! @rleungx

Can you try it again?

Smityz · 2024-04-10T10:05:34Z

Thank you! @rleungx

Can you try it again?

I will try later

lhy1024 · 2024-05-20T04:18:58Z

/cherry-pick release-6.5

lhy1024 · 2024-05-20T04:19:01Z

/cherry-pick release-7.1

lhy1024 · 2024-05-20T04:19:05Z

/cherry-pick release-7.5

lhy1024 · 2024-05-20T04:19:09Z

/cherry-pick release-8.1

ti-chi-bot · 2024-05-20T04:19:34Z

@lhy1024: new pull request created to branch release-6.5: #8195.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-05-20T04:19:37Z

@lhy1024: new pull request created to branch release-7.1: #8196.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-05-20T04:19:41Z

@lhy1024: new pull request created to branch release-7.5: #8197.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-05-20T04:19:45Z

@lhy1024: new pull request created to branch release-8.1: #8198.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #7808 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: lhy1024 <liuhanyang@pingcap.com>

close #7808 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close #7808 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>

close #7808 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

fix the down peer cannot be repaired

f186939

Signed-off-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 28, 2024

ti-chi-bot bot requested review from JmPotato and lhy1024 March 28, 2024 09:19

ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2024

rleungx requested review from nolouch and CabinfeverB and removed request for lhy1024 March 28, 2024 09:20

CabinfeverB reviewed Apr 9, 2024

View reviewed changes

CabinfeverB approved these changes Apr 9, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2024

nolouch approved these changes Apr 10, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 10, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2024

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Apr 10, 2024

Merge branch 'master' into fix-replace

6f425bc

ti-chi-bot bot merged commit fecffc3 into tikv:master Apr 10, 2024
22 checks passed

rleungx deleted the fix-replace branch April 10, 2024 08:10

ti-chi-bot mentioned this pull request May 20, 2024

schedule: fix the down peer cannot be repaired (#7996) #8195

Merged

ti-chi-bot mentioned this pull request May 20, 2024

schedule: fix the down peer cannot be repaired (#7996) #8196

Merged

This was referenced May 20, 2024

schedule: fix the down peer cannot be repaired (#7996) #8197

Merged

schedule: fix the down peer cannot be repaired (#7996) #8198

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Jun 4, 2024

schedule: fix the down peer cannot be repaired (#7996) (#8195)

52464f0

close #7808 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

schedule: fix the down peer cannot be repaired #7996

schedule: fix the down peer cannot be repaired #7996

rleungx commented Mar 28, 2024

ti-chi-bot bot commented Mar 28, 2024 •

edited

Loading

codecov bot commented Mar 28, 2024 •

edited

Loading

CabinfeverB Apr 9, 2024

rleungx Apr 9, 2024

nolouch commented Apr 10, 2024

ti-chi-bot bot commented Apr 10, 2024

ti-chi-bot bot commented Apr 10, 2024

CabinfeverB commented Apr 10, 2024

CabinfeverB commented Apr 10, 2024

ti-chi-bot bot commented Apr 10, 2024

Smityz commented Apr 10, 2024

rleungx commented Apr 10, 2024

Smityz commented Apr 10, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

schedule: fix the down peer cannot be repaired #7996

schedule: fix the down peer cannot be repaired #7996

Conversation

rleungx commented Mar 28, 2024

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Mar 28, 2024 • edited Loading

codecov bot commented Mar 28, 2024 • edited Loading

Codecov Report

CabinfeverB Apr 9, 2024

Choose a reason for hiding this comment

rleungx Apr 9, 2024

Choose a reason for hiding this comment

nolouch commented Apr 10, 2024

ti-chi-bot bot commented Apr 10, 2024

ti-chi-bot bot commented Apr 10, 2024

CabinfeverB commented Apr 10, 2024

CabinfeverB commented Apr 10, 2024

ti-chi-bot bot commented Apr 10, 2024

Smityz commented Apr 10, 2024

rleungx commented Apr 10, 2024

Smityz commented Apr 10, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

lhy1024 commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot commented May 20, 2024

ti-chi-bot bot commented Mar 28, 2024 •

edited

Loading

codecov bot commented Mar 28, 2024 •

edited

Loading