-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: tsoRequest should return when in dispatching but context done #7862
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ci panic panic: [tso] timestamp fallback
goroutine 533993 [running]:
go.uber.org/zap/zapcore.CheckWriteAction.OnWrite(0x2, 0xc00b726b60, {0x5b28442?, 0x37?, 0x0?})
/home/runner/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/entry.go:196 +0x9f
go.uber.org/zap/zapcore.(*CheckedEntry).Write(0xc00b726b60, {0xc0006f9500, 0xc, 0xc})
/home/runner/go/pkg/mod/go.uber.org/zap@v1.26.0/zapcore/entry.go:262 +0x5c2
go.uber.org/zap.(*Logger).Panic(0x6af0d20?, {0x4714c01, 0x18}, {0xc0006f9500, 0xc, 0xc})
/home/runner/go/pkg/mod/go.uber.org/zap@v1.26.0/logger.go:284 +0x68
github.com/pingcap/log.Panic({0x4714c01, 0x18}, {0xc0006f9500, 0xc, 0xc})
/home/runner/go/pkg/mod/github.com/pingcap/log@v1.1.1-0.20221110025148-ca232912c9f3/global.go:54 +0x72
github.com/tikv/pd/client.(*tsoClient).compareAndSwapTS(0xc00b9ee100, {0x46e08ee, 0x6}, 0xc00babc880, 0x18df8c9be96, 0x6a7)
/home/runner/work/pd/pd/client/tso_dispatcher.go:828 +0x12ee
github.com/tikv/pd/client.(*tsoClient).processRequests(0xc00b9ee100, {0x552b120, 0xc00baae520}, {0x46e08ee, 0x6}, 0xc00b3e35e0, {0x0, 0x0, 0x0})
/home/runner/work/pd/pd/client/tso_dispatcher.go:801 +0x80f
github.com/tikv/pd/client.(*tsoClient).handleDispatcher(0xc00b9ee100, {0x5540058, 0xc00b3e3590}, {0x46e08ee, 0x6}, 0xc00b3e35e0)
/home/runner/work/pd/pd/client/tso_dispatcher.go:503 +0x1ef8
created by github.com/tikv/pd/client.(*tsoClient).createTSODispatcher in goroutine 533838
/home/runner/work/pd/pd/client/tso_dispatcher.go:334 +0x84e
FAIL github.com/tikv/pd/tests/integrations/mcs/tso 77.766s
FAIL https://github.com/tikv/pd/actions/runs/8107182719/job/22158279341?pr=7862#step:5:38038 |
/hold |
The log is similar to #6698 and #6770, I think the PR not to introduce this problem |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7862 +/- ##
==========================================
+ Coverage 73.49% 73.53% +0.04%
==========================================
Files 432 432
Lines 47958 47967 +9
==========================================
+ Hits 35245 35273 +28
+ Misses 9667 9658 -9
+ Partials 3046 3036 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
/hold cancel |
/merge |
@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2e413ca
|
What problem does this PR solve?
Issue Number: close #7864
What is changed and how does it work?
use select to watch context.Done()
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note