Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to v7.1.4-d74e7a85 [release-7.1] #7856

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Feb 28, 2024

What problem does this PR solve?

Issue Number: ref #4257 #7561

Update TiDB Dashboard to v7.1.4-d74e7a85.

Release note

None

image

baurine and others added 3 commits February 28, 2024 16:54
close tikv#7612

Signed-off-by: baurine <2008.hbl@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
…v#7563)

close tikv#7561

Pass TLS info to dashboard to fix TiKV heap profiling

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2024
Signed-off-by: baurine <2008.hbl@gmail.com>
@baurine baurine force-pushed the chore/update-tidb-dashboard-7.1 branch from 4f7fe37 to a395839 Compare February 28, 2024 09:11
Copy link
Contributor

ti-chi-bot bot commented Feb 28, 2024

@mornyx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 28, 2024
@mornyx
Copy link
Contributor

mornyx commented Feb 29, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

@mornyx: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 29, 2024
@rleungx
Copy link
Member

rleungx commented Feb 29, 2024

The data race is fixed by #6370

@rleungx
Copy link
Member

rleungx commented Feb 29, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 29, 2024
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 29, 2024
@rleungx
Copy link
Member

rleungx commented Feb 29, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

This pull request has been accepted and is ready to merge.

Commit hash: a395839

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8e97f3b into tikv:release-7.1 Feb 29, 2024
17 checks passed
@baurine baurine deleted the chore/update-tidb-dashboard-7.1 branch February 29, 2024 03:10
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants