-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: improve flow update #7791
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
bytesUnit = 8 * units.MiB | ||
keysUint = 8 * units.KiB | ||
queryUnit = 1 * units.KiB | ||
bytesUnit = 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we use it, we need to note that item of tikv heartbeat is the cumulative, which is used for hotspot determination is the rate.
For example, if the hotKeysUint is 256, the calculated rate is 25.6 for reads and 4.2 for writes, which is lower than the threshold for the hot side, so it won't be treated as a hot region.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7791 +/- ##
==========================================
- Coverage 73.55% 73.46% -0.10%
==========================================
Files 432 432
Lines 47793 47836 +43
==========================================
- Hits 35153 35141 -12
- Misses 9612 9656 +44
- Partials 3028 3039 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some tests for API?
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@rleungx: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge cancel |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2dd5abd
|
What problem does this PR solve?
Issue Number: Ref #7703.
What is changed and how does it work?
Check List
Tests
After this PR:
Release note