Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: clean up handling metrics process #7370

Merged
merged 10 commits into from
Nov 21, 2023
Merged

*: clean up handling metrics process #7370

merged 10 commits into from
Nov 21, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 15, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #5839. close #7391

What is changed and how does it work?

This PR is used to reduce unnecessary collection functions.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 15, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 15, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Nov 20, 2023
@rleungx rleungx marked this pull request as ready for review November 20, 2023 06:21
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2023
@rleungx rleungx requested review from CabinfeverB and removed request for disksing November 20, 2023 06:22
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

Merging #7370 (cabf1b8) into master (89c8374) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7370      +/-   ##
==========================================
- Coverage   74.26%   74.23%   -0.04%     
==========================================
  Files         451      451              
  Lines       49119    49111       -8     
==========================================
- Hits        36480    36457      -23     
- Misses       9424     9435      +11     
- Partials     3215     3219       +4
Flag Coverage Δ
unittests 74.23% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lhy1024
lhy1024 reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

pkg/mcs/scheduling/server/cluster.go
}

func (c *Cluster) resetClusterMetrics() {
if c.regionStats == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2023
@rleungx
dynamically enable scheduling service
d53107a 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
extract scheduling control flow from cluster
8c264b4 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
fix tests
937fc47 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
dynamic enable scheduling jobs
7f048f3 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
add test
cf08a8b 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
resolve conflicts
7159ce0 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
address the comment
2a1c103 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
clean up handling metrics process
1ee573d 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
resolve conflicts
09360e5 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
fix the test
cabf1b8 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 21, 2023
@rleungx
Copy link
Member Author

rleungx commented Nov 21, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cabf1b8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit f9f9be6 into tikv:master Nov 21, 2023
26 checks passed
@rleungx rleungx deleted the cleanup-metrics branch November 21, 2023 04:04
@rleungx rleungx mentioned this pull request Nov 30, 2023
Closed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@rleungx
*: clean up handling metrics process (tikv#7370)
2cf969b 
ref tikv#5839, close tikv#7391

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race in TestRaftClusterMultipleRestart
3 participants
@rleungx @lhy1024 @CabinfeverB