checker: refactor fixOrphanPeers

[lhy1024]

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

• Unit test

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• nolouch
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[lhy1024]

/merge

[ti-chi-bot]

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: b6aa27d

[rleungx]

ci failed

[rleungx]

/hold

[codecov]

Codecov Report

Merging #7342 (1ce8393) into master (afe6afc) will increase coverage by 0.13%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 1ce8393 differs from pull request most recent head 153452c. Consider uploading reports for the commit 153452c to get more accurate results

@@            Coverage Diff             @@
##           master    #7342      +/-   ##
==========================================
+ Coverage   74.33%   74.46%   +0.13%     
==========================================
  Files         446      446              
  Lines       48682    48437     -245     
==========================================
- Hits        36190    36071     -119     
+ Misses       9267     9177      -90     
+ Partials     3225     3189      -36     

Flag	Coverage Δ
unittests	74.46% <100.00%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[rleungx]

/hold cancel

[lhy1024]

/merge

[ti-chi-bot]

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 1ce8393

[ti-chi-bot]

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.