Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: update hotfix version (#7303) #7307

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7303

What problem does this PR solve?

Issue Number: Close #7302

What is changed and how does it work?

update dashboard version to revert pingcap/tidb-dashboard#1583 and pingcap/tidb-dashboard#1587

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: mornyx <mornyx.z@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #7307 (bb978bb) into release-7.5 (7b3611a) will decrease coverage by 0.07%.
Report is 1 commits behind head on release-7.5.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-7.5    #7307      +/-   ##
===============================================
- Coverage        74.60%   74.54%   -0.07%     
===============================================
  Files              442      442              
  Lines            47779    47780       +1     
===============================================
- Hits             35645    35616      -29     
- Misses            8976     9004      +28     
- Partials          3158     3160       +2     
Flag Coverage Δ
unittests 74.54% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2023
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 2, 2023
@nolouch
Copy link
Contributor

nolouch commented Nov 2, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: bb978bb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 595d5b0 into tikv:release-7.5 Nov 2, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants