Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcs: support hotspot http interface in scheduling server #7184

Merged
merged 10 commits into from
Oct 16, 2023
Merged

mcs: support hotspot http interface in scheduling server #7184

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06cb2e6
refactor for rw
lhy1024 Oct 9, 2023
a4fa9db
refactor hot handler
lhy1024 Oct 9, 2023
13228b5
add four interfaces
lhy1024 Oct 9, 2023
b6bf7e1
add TODO about history hot region
lhy1024 Oct 10, 2023
e1ba317
add test
lhy1024 Oct 10, 2023
b18b53e
address comments
lhy1024 Oct 11, 2023
29645d3
add some comments
lhy1024 Oct 12, 2023
a768778
Merge branch 'master' into sche-redirect5
lhy1024 Oct 12, 2023
71423b0
address comments
lhy1024 Oct 13, 2023
ebc0c22
Merge branch 'master' into sche-redirect5
ti-chi-bot[bot] Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion server/api/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ func NewHandler(_ context.Context, svr *server.Server) (http.Handler, apiutil.AP
// "/schedulers", http.MethodGet
// "/schedulers/{name}", http.MethodPost
// "/schedulers/diagnostic/{name}", http.MethodGet
// “/hotspot/regions/read”, http.MethodGet
// “/hotspot/regions/write”, http.MethodGet
// “/hotspot/regions/history, http.MethodGet
// “/hotspot/stores”, http.MethodGet
// “/hotspot/buckets, http.MethodGet
lhy1024 marked this conversation as resolved.
Show resolved Hide resolved
// Following requests are **not** redirected:
// "/schedulers", http.MethodPost
// "/schedulers/{name}", http.MethodDelete
Expand All @@ -77,7 +82,7 @@ func NewHandler(_ context.Context, svr *server.Server) (http.Handler, apiutil.AP
prefix+"/hotspot",
scheapi.APIPathPrefix+"/hotspot",
mcs.SchedulingServiceName,
[]string{http.MethodPost, http.MethodGet, http.MethodDelete}),
[]string{http.MethodGet}),
// because the writing of all the meta information of the scheduling service is in the API server,
// we should not post and delete the scheduler directly in the scheduling service.
serverapi.MicroserviceRedirectRule(
Expand Down
Loading