Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, server: add env to manage the service mode #7018

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5766.

What is changed and how does it work?

Add env `PD_SERVICE_MODE` to manage the service mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Support to bootstrap the PD service with environment variable `PD_SERVICE_MODE`.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 31, 2023
@JmPotato JmPotato requested a review from rleungx August 31, 2023 05:59
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 31, 2023
@JmPotato JmPotato changed the title cmd,server: add env to manage the service mode cmd, server: add env to manage the service mode Aug 31, 2023
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 31, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 345ebd6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #7018 (345ebd6) into master (da1b937) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7018      +/-   ##
==========================================
+ Coverage   74.16%   74.26%   +0.09%     
==========================================
  Files         433      433              
  Lines       46101    46101              
==========================================
+ Hits        34193    34235      +42     
+ Misses       8890     8858      -32     
+ Partials     3018     3008      -10     
Flag Coverage Δ
unittests 74.26% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 7a4e1e2 into tikv:master Aug 31, 2023
24 checks passed
@JmPotato JmPotato deleted the cp_env_boot_api branch August 31, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants