Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the initialization of evict-slow-trend scheduler in init_schedulers. #6994

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Revert the initialization of evict-slow-trend scheduler in init_schedulers. #6994

merged 4 commits into from
Aug 28, 2023

Conversation

LykxSassinator
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6981

What is changed and how does it work?

In this pr:
+ Revert and re-factor the initialization of `evict-slow-trend` scheduler when starting with `raft-kv2`.
+ Fix typo errors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@LykxSassinator
Revert the initialization of evict-slow-trend scheduler in `init_sche…
2efca1d 
…dulers`.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx August 28, 2023 09:15
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2023
@LykxSassinator
Polish codes.
94a7766 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Merge branch 'master' into revert_init_v2
dd3614d
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 28, 2023
nolouch
nolouch reviewed Aug 28, 2023
View reviewed changes
pkg/schedule/coordinator.go
}
// If the cluster was set up with `raft-kv2` engine, this cluster should
// enable `evict-slow-trend` scheduler as default.
if c.GetCluster().GetStoreConfig().IsRaftKV2() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unbelievable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it will not influence the current strategy when initializing.

@LykxSassinator
Polish annotations.
c70f80f 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #6994 (c70f80f) into master (6307aa8) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 71.14%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6994      +/-   ##
==========================================
- Coverage   74.21%   74.21%   -0.01%     
==========================================
  Files         433      433              
  Lines       46137    46046      -91     
==========================================
- Hits        34240    34171      -69     
+ Misses       8871     8863       -8     
+ Partials     3026     3012      -14
Flag Coverage Δ
unittests 74.21% <71.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor

nolouch commented Aug 28, 2023 •
edited
Loading

/merge

BTW, We need unify the bootstrap method after this. we can default enable this scheduler, and judge IsRaftKV inner the scheduler. current implementation will let some issues like if user manually delete the slowTrendScheduler, after restart, the scheduler will be recreated.

cc @LykxSassinator @CabinfeverB

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: c70f80f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 28, 2023
@nolouch
Copy link
Contributor

nolouch commented Aug 28, 2023

/test build

@ti-chi-bot ti-chi-bot bot merged commit b905214 into tikv:master Aug 28, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch left review comments

@HuSharp HuSharp HuSharp left review comments

@bufferflies bufferflies bufferflies approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LykxSassinator @nolouch @bufferflies @CabinfeverB @HuSharp