-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hot_region_storage: Fix a typo in comment #6990
Conversation
Fix a typo
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @ZhuohaoHe. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -90,7 +90,7 @@ type HistoryHotRegion struct { | |||
|
|||
// HotRegionStorageHandler help hot region storage get hot region info. | |||
type HotRegionStorageHandler interface { | |||
// PackHistoryHotWriteRegions get read hot region info in HistoryHotRegion form. | |||
// PackHistoryHotReadRegions get read hot region info in HistoryHotRegion form. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
btw, I noticed a missing s
in the comment for GetHotRegionsWriteInterval
, Could you help fix that as well?
Please use option |
/ok-to-test |
What problem does this PR solve?
Issue Number: ref #6989
What is changed and how does it work?
Check List
None
Release note