Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot_region_storage: Fix a typo in comment #6990

Closed
wants to merge 1 commit into from
Closed

hot_region_storage: Fix a typo in comment #6990

wants to merge 1 commit into from

Conversation

ZzzhHe
Copy link
Contributor

@ZzzhHe ZzzhHe commented Aug 28, 2023

What problem does this PR solve?

Issue Number: ref #6989

What is changed and how does it work?


https://github.com/tikv/pd/blob/50368e57bde37a4e4994ffe4da4394433799ac71/pkg/storage/hot_region_storage.go#L93

* fix a typo by changing "PackHistoryHotWriteRegions" to "PackHistoryHotReadRegions"

Check List

None

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 28, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx August 28, 2023 02:11
@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Aug 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2023

Hi @ZhuohaoHe. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2023
@@ -90,7 +90,7 @@ type HistoryHotRegion struct {

// HotRegionStorageHandler help hot region storage get hot region info.
type HotRegionStorageHandler interface {
// PackHistoryHotWriteRegions get read hot region info in HistoryHotRegion form.
// PackHistoryHotReadRegions get read hot region info in HistoryHotRegion form.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!
btw, I noticed a missing s in the comment for GetHotRegionsWriteInterval, Could you help fix that as well?

@HuSharp
Copy link
Member

HuSharp commented Aug 28, 2023

Please use option git commit -s to sign off your commits :)
https://github.com/tikv/pd/blob/master/CONTRIBUTING.md#signing-off-the-commit

@HuSharp
Copy link
Member

HuSharp commented Aug 28, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 28, 2023
@ZzzhHe ZzzhHe closed this by deleting the head repository Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants