Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: supports build pd-server with fail point #6946

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Aug 10, 2023

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how does it work?

In order can use fail points in testing, need to build a special binary
- supports build pd-server with fail point

Check List

Tests

  • Manual test (add detailed scripts or steps below)
make pd-server-failpoint 
➜  bin git:(support-make-failpoint) tiup playground v7.1.1  --tiflash=0  --pd=1 --pd.binpath=./pd-server
➜  bin git:(support-make-failpoint) curl http://127.0.0.1:2379/pd/api/v1/fail
malformed request URI
➜  bin git:(support-make-failpoint) curl http://127.0.0.1:2379/pd/api/v1/fail/test
failed to GET: error on test: failpoint: failpoint does not exist
➜  bin git:(support-make-failpoint) curl -X PUT -d 'return(3474484975246189105)'  http://127.0.0.1:2379/pd/api/v1/fail/github.com/tikv/pd/server/exitCampaignLeader
➜  bin git:(support-make-failpoint) curl  http://127.0.0.1:2379/pd/api/v1/fail/                      
=return(3474484975246189105)
pd/server/exitCampaignLeader=return(3474484975246189105)


make pd-server
➜  bin git:(support-make-failpoint) tiup playground v7.1.1  --tiflash=0  --pd=1 --pd.binpath=./pd-server
➜  bin git:(support-make-failpoint) curl  http://127.0.0.1:2379/pd/api/v1/fail/
404 page not found

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 10, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx August 10, 2023 09:21
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2023
@nolouch nolouch requested review from HuSharp and removed request for disksing August 10, 2023 09:22
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #6946 (0f390db) into master (70e9ffc) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6946      +/-   ##
==========================================
- Coverage   74.36%   74.33%   -0.04%     
==========================================
  Files         427      427              
  Lines       45327    45334       +7     
==========================================
- Hits        33706    33697       -9     
- Misses       8651     8669      +18     
+ Partials     2970     2968       -2     
Flag Coverage Δ
unittests 74.33% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2023
@nolouch
Copy link
Contributor Author

nolouch commented Aug 16, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4dd911e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 346e771 into tikv:master Aug 16, 2023
21 of 23 checks passed
@nolouch nolouch deleted the support-make-failpoint branch August 17, 2023 04:50
mittalrishabh pushed a commit to mittalrishabh/pd that referenced this pull request Aug 18, 2023
close tikv#4399

In order can use fail points in testing, need to build a special binary
- supports build pd-server with fail point

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: rishabh_mittal <mittalrishabh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue
3 participants