-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: removes redundant integration files and generated by script #6909
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
7e2bd96
to
c06af72
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6909 +/- ##
==========================================
- Coverage 74.30% 74.20% -0.10%
==========================================
Files 427 427
Lines 45224 45144 -80
==========================================
- Hits 33603 33501 -102
- Misses 8661 8684 +23
+ Partials 2960 2959 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
overall lgtm. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
pkg/utils/grpcutil/grpcutil_test.go
Outdated
"testing" | ||
|
||
"github.com/pingcap/errors" | ||
"github.com/stretchr/testify/require" | ||
"github.com/tikv/pd/pkg/errs" | ||
) | ||
|
||
var ( | ||
certPath = "../../../tests/integrations/client/cert" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use an absolute path. the script generates can to a tmp
path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use an absolute path
It may be necessary to merge the master and then change it to absolute path
the script generates can to a tmp path.
yes, fixed
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: dbde1d2
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #6910
What is changed and how does it work?
These are redundant files that are only used in the integration, we can delete them and generate them with a script.
Check List
Tests
Release note