Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: removes redundant integration files and generated by script #6909

Merged
merged 8 commits into from
Aug 10, 2023

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Aug 8, 2023

What problem does this PR solve?

Issue Number: Close #6910

What is changed and how does it work?

These are redundant files that are only used in the integration, we can delete them and generate them with a script.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot requested a review from nolouch August 8, 2023 07:28
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2023
@HuSharp HuSharp marked this pull request as ready for review August 8, 2023 07:33
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2023
@HuSharp HuSharp changed the title tests: remove redundant file by generate tests: removes redundant integration files and generated by script Aug 8, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 8, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the remove_cert branch 2 times, most recently from 7e2bd96 to c06af72 Compare August 8, 2023 08:56
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #6909 (dbde1d2) into master (af35e15) will decrease coverage by 0.10%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head dbde1d2 differs from pull request most recent head f575d54. Consider uploading reports for the commit f575d54 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6909      +/-   ##
==========================================
- Coverage   74.30%   74.20%   -0.10%     
==========================================
  Files         427      427              
  Lines       45224    45144      -80     
==========================================
- Hits        33603    33501     -102     
- Misses       8661     8684      +23     
+ Partials     2960     2959       -1     
Flag Coverage Δ
unittests 74.20% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor

nolouch commented Aug 9, 2023

overall lgtm.
ci failed.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
"testing"

"github.com/pingcap/errors"
"github.com/stretchr/testify/require"
"github.com/tikv/pd/pkg/errs"
)

var (
certPath = "../../../tests/integrations/client/cert"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use an absolute path. the script generates can to a tmp path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use an absolute path

It may be necessary to merge the master and then change it to absolute path

the script generates can to a tmp path.

yes, fixed

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2023
@nolouch
Copy link
Contributor

nolouch commented Aug 10, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

This pull request has been accepted and is ready to merge.

Commit hash: dbde1d2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit c98f6da into tikv:master Aug 10, 2023
19 checks passed
@HuSharp HuSharp deleted the remove_cert branch August 10, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removes redundant integration files and generated by script
3 participants