Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: supports requests can redirect from leader to follower #6905

Closed
wants to merge 3 commits into from

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Aug 8, 2023

What problem does this PR solve?

Issue Number: Close #6904

What is changed and how does it work?

Reduce the leader pressure by proxy requests to followers
- supports requests can redirect from leader to follower 

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and Yisaer August 8, 2023 04:36
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 8, 2023
@nolouch nolouch requested review from lhy1024 and rleungx and removed request for disksing and Yisaer August 8, 2023 04:36
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2023
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #6905 (82a4c02) into master (ebd2cfe) will increase coverage by 0.00%.
Report is 63 commits behind head on master.
The diff coverage is 88.17%.

@@           Coverage Diff           @@
##           master    #6905   +/-   ##
=======================================
  Coverage   74.21%   74.22%           
=======================================
  Files         427      427           
  Lines       45127    45172   +45     
=======================================
+ Hits        33491    33528   +37     
+ Misses       8685     8683    -2     
- Partials     2951     2961   +10     
Flag Coverage Δ
unittests 74.22% <88.17%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch nolouch closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce the leader pressure by proxy request to followers
1 participant