Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: use history loads in single rocksdb #6807

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 13, 2023

What problem does this PR solve?

Issue Number: Ref #6297

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    compare 4466afa with 7.2 in bench bot

some cases increase: oltp_delete, update_index, update_non_index, tpcc
Image
Image
Image
Image

some case unchange: hzbank, oltp_point_select, read only, read_write, random points, random range, shenma
Image
Image
Image
Image
Image
Image
Image

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 13, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and HunDunDM July 13, 2023 11:13
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #6807 (84cdb25) into master (ef81248) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 84cdb25 differs from pull request most recent head ce52b32. Consider uploading reports for the commit ce52b32 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6807   +/-   ##
=======================================
  Coverage   74.17%   74.18%           
=======================================
  Files         419      418    -1     
  Lines       44079    43995   -84     
=======================================
- Hits        32697    32638   -59     
+ Misses       8470     8456   -14     
+ Partials     2912     2901   -11     
Flag Coverage Δ
unittests 74.18% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 13, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 13, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 14, 2023

/run-build-arm64 comment=true

2 similar comments
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 14, 2023

/run-build-arm64 comment=true

@purelind
Copy link
Contributor

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Jul 14, 2023

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 19, 2023

compare 4466afa with 7.2 in bench bot

  1. some cases increase: oltp_delete, update_index, update_non_index, tpcc

  2. some case unchange: hzbank, oltp_point_select, read only, read_write, randoim points, randoim range, shenma

  3. some case decrease: oltp_insert, oltp_write_only, oltp_read_write
    Image
    Image

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 21, 2023

For oltp_insert

If test with warm, this pr has lower qps than 7.2
7c990fbc-305f-40fe-8d32-fa3d68f67a04
63a36f7b-d154-4b0b-b798-0f3ce9cb17fc

If test without warm, this pr has higher qps than 7.2
93a01ff9-9380-4fe0-a307-f7c6eb986134
1a5756fa-5c3a-440d-ae58-cdfadace03e1

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 31, 2023

After discussion with @bufferflies and @Yui-Song, we will close warm in oltp_insert

@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 changed the title [DNM] scheduler: use history loads in single rocksdb scheduler: use history loads in single rocksdb Jul 31, 2023
@lhy1024 lhy1024 marked this pull request as ready for review July 31, 2023 06:05
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@lhy1024 lhy1024 requested review from bufferflies and nolouch and removed request for disksing and HunDunDM July 31, 2023 06:05
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-linked-issue labels Jul 31, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 31, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 31, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 31, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 84cdb25

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 31, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 31, 2023

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b9da67f into tikv:master Jul 31, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants