-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swagger: block swagger url if disbale swagger server #6785
Conversation
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6785 +/- ##
==========================================
+ Coverage 74.17% 74.28% +0.10%
==========================================
Files 413 412 -1
Lines 43373 43369 -4
==========================================
+ Hits 32172 32215 +43
+ Misses 8318 8282 -36
+ Partials 2883 2872 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: bufferflies <1045931706@qq.com>
/merge |
@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4dd6af2
|
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
close tikv#6786 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
close #6786 /swagger/* return 404 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: bufferflies <1045931706@qq.com> Co-authored-by: buffer <1045931706@qq.com> Co-authored-by: bufferflies <1045931706@qq.com>
What problem does this PR solve?
Issue Number: Close #6786
What is changed and how does it work?
Check List
Tests
Before
curl xxxx:2379/swagger/ui/index
After
curl xxxx:2379/swagger/ui/index
swagger=1 make
Code changes
Side effects
Related changes
Release note