Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config, cluster: add an option to halt the cluster scheduling (#6498) #6558

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6498

What problem does this PR solve?

Issue Number: ref #6493.

What is changed and how does it work?

Add an option to halt the cluster scheduling.

Check List

Tests

  • Unit test
  • Integration test

During the halt:

image

image

image

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 6, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@HuSharp
Copy link
Member

HuSharp commented Jun 6, 2023

image

image

image

image

@HuSharp
Copy link
Member

HuSharp commented Jun 6, 2023

@nolouch @CabinfeverB @bufferflies show local test result PTAL, thx!

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 68.96% and project coverage change: -0.01 ⚠️

Comparison is base (8e9d0c4) 75.64% compared to head (ddc7296) 75.64%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6558      +/-   ##
===============================================
- Coverage        75.64%   75.64%   -0.01%     
===============================================
  Files              330      330              
  Lines            33091    33113      +22     
===============================================
+ Hits             25033    25048      +15     
- Misses            5904     5907       +3     
- Partials          2154     2158       +4     
Flag Coverage Δ
unittests 75.64% <68.96%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mock/mockcluster/mockcluster.go 93.76% <0.00%> (-0.23%) ⬇️
server/cluster/diagnostic_manager.go 76.34% <ø> (+4.30%) ⬆️
server/config/persist_options.go 92.90% <25.00%> (-0.24%) ⬇️
server/cluster/cluster.go 81.22% <66.66%> (-0.37%) ⬇️
server/cluster/coordinator.go 72.79% <75.00%> (+0.99%) ⬆️
server/cluster/cluster_worker.go 70.00% <100.00%> (ø)
server/cluster/metrics.go 100.00% <100.00%> (ø)
server/config/config.go 78.99% <100.00%> (+0.08%) ⬆️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HuSharp HuSharp requested review from nolouch, bufferflies, CabinfeverB and rleungx and removed request for JmPotato and lhy1024 June 6, 2023 05:23
@HuSharp HuSharp force-pushed the cherry-pick-6498-to-release-6.5 branch from 005b898 to a1d9783 Compare June 6, 2023 05:29
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 6, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the cherry-pick-6498-to-release-6.5 branch from a1d9783 to ddc7296 Compare June 6, 2023 05:31
@bufferflies
Copy link
Contributor

any test ??

@HuSharp
Copy link
Member

HuSharp commented Jun 6, 2023

image

image

image

image

The above figure shows the local test by tiup @bufferflies

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 6, 2023
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ddc7296

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2023
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 6, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 410b176 into tikv:release-6.5 Jun 6, 2023
@HuSharp HuSharp deleted the cherry-pick-6498-to-release-6.5 branch June 6, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants